Reduce dependencies of catalog-protos #34105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
mz_catalog_types
branch
from
28b94cc to
d6b84af
Compare
The mz-catalog-protos crate has a large number of dependencies that aren't strictly needed. Sepcifically, it transitively depends on timely and the likes, which is not ideal for a crate that is supposed to maintain the catalog. This change aims at extracting types that have a representation in the catalog into a separate crate that does not have any odd dependency. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
mz_catalog_types
branch
from
d6b84af to
2a868b3
Compare
antiguru
commented
Nov 13, 2025
| } | ||
| } | ||
|
|
||
| impl RustType<crate::objects::Timestamp> for Timestamp { |
Member
Author
There was a problem hiding this comment.
We're not using this implementation. Should remove the Timestamp type from the proto, but that'd require a migration.
Comment on lines
-249
to
-252
| impl Columnation for AclMode { | ||
| type InnerRegion = CopyRegion<AclMode>; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
We're not using the columnation implementations 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mz-catalog-protos crate has a large number of dependencies that aren't strictly needed. Sepcifically, it transitively depends on timely and the likes, which is not ideal for a crate that is supposed to maintain the catalog. This change aims at extracting types that have a representation in the catalog into a separate crate that does not have any odd dependency.